Improve support for URL query parameters #96
Conversation
1. Query parameters are observed on initial page load. (They were previously ignored.) 2. Query parameters are preserved when clicking on an <a> element. (They were previously discarded.) 3. Hash fragment is preserved when clicking on an <a> element in HTML5 mode. (No change to behavior when using URL fragment for routing.) 4. Browser's backward/forward preserve query parameters (They were previously discarded.)
|
@pavelgj I see you commenting on other PRs today... can I convince you to look at mine? |
| } else if (anchor.hash == '') { | ||
| _router.gotoUrl('${anchor.pathname}${anchor.search}'); | ||
| } else { | ||
| Element el = document.querySelector(anchor.hash); |
There was a problem hiding this comment.
This doesn't make sense... why are you querying by the value of the hash?
|
Merged via 7cd7257 |
|
How would you define a custom WindowClickHandler? You need a linkMatcher, router asf... https://github.com/angular/route.dart/blob/master/lib/click_handler.dart |
When you put is this way, it makes sense. However it's not what your code does: Element el = document.querySelector(anchor.hash);
if (el != null) {
Rectangle r = el.getBoundingClientRect();
_window.scroll(0, r.top.floor());
}AFAIK, default browser behavior is something more like Element el = document.querySelector('a[name=${anchor.hash}]');But in this case sanitizing that hash to fit into CSS selector would be a pain... |
Route.dart's support for query parameters, e.g.
?foo=bar&baz=batis abysmal.Route.parametersshould parse path and query string #78)onpopstateevents. (No issue opened.)I spent almost 3 full days trying to hack around all of its idiosyncracies and finally gave up in frustration. It turns out to be much easier just to fix route.dart.
Caveats
MockWindowdoesn't have anonPopStatemember, and it seems like a lot of work to properly mockonPopState. There are no existing tests for HTML5 routing that I can mimic — the tests are exclusively for fragment routing.